Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

[Julien Grall <julien.grall@xxxxxxx>]

Hello Chris,

On 17/04/2017 16:03, Chris Patterson wrote:
> > > +static const char * const tegra_dt_compat[] __initconst =
> > > +{
> > > +    "nvidia,tegra120",  /* Tegra K1 */
> > This is still tegra120 (not tegra124), is that intended? If so, it is
> > still missing from arch/arm*/boot/dts. Do you have a pointer?
> It was not intended; thank you for catching it. I must have lost that
> fixup somewhere along the way...
>
> > Also, do we need both tegra_dt_compat and tegra_interrupt_compat? Can we
> > keep only one?
> The purpose of tegra_interrupt_compat is to maintain a tegra-specific
> whitelist of interrupt controllers we know how to route.  Presumably,
> there may be custom boards out there that may have additional
> interrupt routing capabilities that this patch set would not support
> as-is.  I'm not sure of an appropriate way to maintain that logic and
> merge them.  However, I am certainly open to suggestion, if you have
> any ideas.
Those custom boards would likely have a different machine compatible 
string because the SOC would be different. So I think the 
tegra_interrupt_compat is not necessary.
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel