Re: [Xen-devel] [PATCH] x86/vIO-APIC: fix uninitialized variable warning

[Julien Grall <julien.grall@xxxxxxx>]

On 13/04/17 15:37, Andrew Cooper wrote:
> On 13/04/17 15:29, Jan Beulich wrote:
> > In a release build modern gcc validly complains about "pin" possibly
> > being uninitialized in vioapic_irq_positive_edge().
> >
> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Release-acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> > --- a/xen/arch/x86/hvm/vioapic.c
> > +++ b/xen/arch/x86/hvm/vioapic.c
> > @@ -421,7 +421,11 @@ void vioapic_irq_positive_edge(struct do
> >      struct hvm_vioapic *vioapic = gsi_vioapic(d, irq, &pin);
> >      union vioapic_redir_entry *ent;
> >
> > -    ASSERT(vioapic);
> > +    if ( !vioapic )
> > +    {
> > +        ASSERT_UNREACHABLE();
> > +        return;
> > +    }
> >
> >      HVM_DBG_LOG(DBG_LEVEL_IOAPIC, "irq %x", irq);
--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel