[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [Qemu-devel] [PATCH v3 09/13] qobject: Use simpler QDict/QList scalar insertion macros
Eric Blake <eblake@xxxxxxxxxx> writes: > We now have macros in place to make it less verbose to add a scalar > to QDict and QList, so use them. To make this patch smaller to > review, a couple of subdirectories were done in earlier patches. > > Patch created mechanically via: > spatch --sp-file scripts/coccinelle/qobject.cocci \ > --macro-file scripts/cocci-macro-file.h --dir . --in-place > and needed only one touch-up in monitor.c to avoid a long line. > > Signed-off-by: Eric Blake <eblake@xxxxxxxxxx> > --- > block.c | 45 +++++++++++++++++++-------------------------- > blockdev.c | 30 +++++++++++++----------------- > hw/block/xen_disk.c | 2 +- > hw/usb/xen-usb.c | 12 ++++++------ > monitor.c | 23 +++++++++++------------ > qapi/qmp-event.c | 2 +- > qemu-img.c | 6 +++--- > qemu-io.c | 2 +- > qemu-nbd.c | 2 +- > qobject/qdict.c | 2 +- > target/s390x/cpu_models.c | 4 ++-- > util/qemu-option.c | 2 +- > 12 files changed, 60 insertions(+), 72 deletions(-) Looks like you intent is to split the application of qobject.cocci into block [PATCH 07], tests [PATCH 08] and rest [PATCH 09, i.e. this one]. Okay, although everything on one patch would also be okay for me. However, this patch also contains block stuff: block.c blockdev.c qemu-{img,io,nbd}.c. Move to PATCH 07? _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |