Re: [Xen-devel] [PATCH for-4.9 v3 2/3] x86/atomic: fix clang build

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Tue, Apr 11, 2017 at 12:21:23AM -0600, Jan Beulich wrote:
> >>> On 10.04.17 at 18:46, <roger.pau@xxxxxxxxxx> wrote:
> > I have a (I think) less intrusive fix, which relies on using _Pragma, pasted
> > below. Let me know what you think, and I can formally submit it.
> 
> Personally I like this much better as a workaround, provided the
> omitted warning isn't just cosmetic (i.e. the generated code then
> also matches gcc's rather than doing what the warning suggests
> clang does). I do think, however, that the comment would better
> go next to the #define.

Yes, the generated code matches gcc behavior. I've been told that what might
behave differently is something like:

switch ( foo )
{
case 1:
        while ( ({ if ( bar ) { x = 1; break; } x; }) )
        {
                ...

But this is not the case clearly, and the clang warning is simply a bug.

OK, so let me move the comment with the defines and submit the patch properly,
thanks.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel