[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.9 v2 1/2] xsm: fix clang 3.5 build after c47d1d





On 10/04/17 11:50, Jan Beulich wrote:
On 10.04.17 at 12:39, <julien.grall@xxxxxxx> wrote:
Hi Roger,

On 10/04/17 10:01, Roger Pau Monne wrote:
The changes introduced on c47d1d broke the clang build due to undefined
references to __xsm_action_mismatch_detected, because clang hasn't optimized
the code properly. The following patch allows the clang build to work again,
while keeping the same functionality.

Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Cc: Julien Grall <julien.grall@xxxxxxx>
Cc: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
---
Changes since v1:
 - Remove unused "break".
 - Remove if condition.

This new version does not fix the ARM32 build (though the previous
one does). I still get:

prelink.o: In function `xsm_default_action':
/home/julieng/works/xen/xen/include/xsm/dummy.h:80: undefined reference to
`__xsm_action_mismatch_detected'
arm-linux-gnueabihf-ld: /home/julieng/works/xen/xen/.xen-syms.0: hidden
symbol `__xsm_action_mismatch_detected' isn't defined

I have to admit that I was afraid of this, after having seen this is
an issue for ARM too. I guess the suggested use of a conditional
expression (instead of if/else) needs to be undone, which is quite
sad.

I think this would be the safest for now, I would like to cut an RC soon with what has been pushed before the code freeze. This would mean v1 + removing pointless break.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.