[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v5 for-4.9 1/4] hvm/dmop: Box dmop_bufs rather than passing two parameters around
>>> On 07.04.17 at 21:35, <andrew.cooper3@xxxxxxxxxx> wrote: > --- a/xen/arch/x86/hvm/dm.c > +++ b/xen/arch/x86/hvm/dm.c > @@ -25,6 +25,18 @@ > > #include <xsm/xsm.h> > > +struct dmop_bufs { > +/* > + * Small sanity limit. Enough for all current hypercalls. > + */ > +#define MAX_NR_BUFS 2 > + > + struct xen_dm_op_buf buf[MAX_NR_BUFS]; > + unsigned int nr; > + > +#undef MAX_NR_BUFS What's the use of this constant? This is clearly more cluttering than clarifying things. I'd much appreciate if 2 was used as array dimension right away, and the constant dropped. With that Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |