Re: [Xen-devel] [PATCH 0/5] Towards a restartable oxenstored

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Apr 10, 2017 at 09:10:15AM +0100, Christian Lindig wrote:
> 
> > On 7. Apr 2017, at 14:27, Jonathan Davies <Jonathan.Davies@xxxxxxxxxx> 
> > wrote:
> > 
> > tools/ocaml/xenstored/domain.ml    |  4 ++--
> > tools/ocaml/xenstored/store.ml     |  8 +++++++-
> > tools/ocaml/xenstored/xenstored.ml | 10 ++++++----
> 
> The OCaml code is looking good and I’d be happy to take it as it is. 

Can I translate that to reviewed-by's?

> 
> I noticed that the (existing) code for handling the path for the
> database file uses (^) to construct it. It would be better to use
> Filename.concat and this could have been done as part of this patch.
> Admittedly, this would be mostly cosmetic as it would help mainly
> portability to Windows.
> 

Feel free to submit patches to fix that when the development window
opens.

Wei.

> — Christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel