Re: [Xen-devel] [PATCH v6 21/36] ARM: GICv3: prepare for virtual ITS subnodes

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andre,

On 07/04/2017 18:32, Andre Przywara wrote:
> When creating the device tree for a domain using an emulated GICv3,
> we will later need to add the respective ITS subnodes as well.
> Prepare a stub function to be later filled with the actual code.
make_hwdom_dt_node will only create DT node for the hardware domain. The 
guest DTs will be created by the toolstack.
Please update the commit message accordingly.

> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
> ---
>  xen/arch/arm/gic-v3.c            | 4 +++-
>  xen/include/asm-arm/gic_v3_its.h | 8 ++++++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
> index 54fbb19..2fbcf52 100644
> --- a/xen/arch/arm/gic-v3.c
> +++ b/xen/arch/arm/gic-v3.c
> @@ -1172,8 +1172,10 @@ static int gicv3_make_hwdom_dt_node(const struct domain 
> *d,
>
>      res = fdt_property(fdt, "reg", new_cells, len);
>      xfree(new_cells);
> +    if ( res )
> +        return res;
>
> -    return res;
> +    return gicv3_its_make_dt_nodes(NULL, d, gic, fdt);
I said no to the NULL and explained why on v5. Please address all the 
comments.
Also this should be name gicv3_its_make_hwdom_dt_nodes.

>  }
>
>  static const hw_irq_controller gicv3_host_irq_type = {
> diff --git a/xen/include/asm-arm/gic_v3_its.h b/xen/include/asm-arm/gic_v3_its.h
> index 7470779..09c7117 100644
> --- a/xen/include/asm-arm/gic_v3_its.h
> +++ b/xen/include/asm-arm/gic_v3_its.h
> @@ -220,6 +220,14 @@ static inline void vgic_v3_its_free_domain(struct domain 
> *d)
>
>  #endif /* CONFIG_HAS_ITS */
>
> +static inline int gicv3_its_make_dt_nodes(struct list_head *its_list,
> +                                          const struct domain *d,
> +                                          const struct dt_device_node *gic,
> +                                          void *fdt)
> +{
> +    return 0;
> +}
> +
>  #endif
>
>  /*
Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel