[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 05/30] ARM: GICv3: allocate LPI pending and property table



Hi Andre,

On 06/04/17 15:37, Andre Przywara wrote:
On 06/04/17 13:58, Julien Grall wrote:
Hi Andre,

On 06/04/17 00:18, Andre Przywara wrote:
+static unsigned int max_lpi_bits = 20;
+integer_param("max_lpi_bits", max_lpi_bits);
+
+int gicv3_lpi_init_host_lpis(unsigned int host_lpi_bits)
+{
+    /* An implementation needs to support at least 14 bits of LPI
IDs. */
+    max_lpi_bits = max(max_lpi_bits, 14U);

I think we should warn the user if we don't use his command line. He
might think he can disable LPIs using it.

Done.
Shall this be a warning_add() as well or is a printk() sufficient?

I would go on classic printk. I was even thinking a panic as a user should not do this. It is up to you.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.