Re: [Xen-devel] [PATCH v6 2/2] vgic: refuse irq migration when one is already in progress

[Julien Grall <julien.grall@xxxxxxx>]

Hi Stefano,

On 04/04/17 02:09, Stefano Stabellini wrote:
> diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c
> index 67d75a6..5eef359 100644
> --- a/xen/arch/arm/vgic.c
> +++ b/xen/arch/arm/vgic.c
> @@ -237,18 +237,21 @@ static int vgic_get_virq_priority(struct vcpu *v, 
> unsigned int virq)
>      return priority;
>  }
>
> -void vgic_migrate_irq(struct vcpu *old, struct vcpu *new, unsigned int irq)
> +bool vgic_migrate_irq(struct vcpu *old, struct vcpu *new, unsigned int irq)
>  {
>      unsigned long flags;
>      struct pending_irq *p = irq_to_pending(old, irq);
>
>      /* nothing to do for virtual interrupts */
>      if ( p->desc == NULL )
> -        return;
> +        return true;
>
>      /* migration already in progress, no need to do anything */
>      if ( test_bit(GIC_IRQ_GUEST_MIGRATING, &p->status) )
> -        return;
> +    {
> +        gdprintk(XENLOG_WARNING, "irq %d migration failed: requested while in 
> progress\n", irq);
NIT: %u

Also, I think you want this to be gprintk to have a message appearing on 
non-debug build too.
Otherwise the code looks good to me.

Cheers,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel