Re: [Xen-devel] [PATCH v2 1/5] xen/libcx/tmem: Replace TMEM_RESTORE_NEW with XEN_SYSCTL_TMEM_OP_SET_POOLS

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.04.17 at 21:10, <konrad.wilk@xxxxxxxxxx> wrote:
> This used to be done under TMEM_RESTORE_NEW which was an hypercall
> accessible by the guest. However there are couple of reasons
> not to do it:
>  - No checking of domid on TMEM_RESTORE_NEW which meant that
>    any guest could create TMEM pools for other guests.
>  - The guest can already create pools using TMEM_NEW_POOL
>    (which is limited to guest doing the hypercall)
>  - This functionality is only needed during migration - there
>    is no need for the guest to have this functionality.
> 
> However to move this we also have to allocate the 'struct domain'
> ->tmem pointer. It is by default set to NULL and would be initialized
> via the guest do_tmem() hypercalls. Presumarily that was the
> initial reason that TMEM_RESTORE_NEW was in the guest accessible
> hypercalls.
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx> [libxc change] [libxc change] [libxc 
> change] [libxc change]

What's this four fold repetition?

> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel