[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4] displif: add ABI for para-virtual display




On 04/04/2017 11:07 PM, Konrad Rzeszutek Wilk wrote:
.snip..
+ *----------------------------- Protocol version ------------------------------
+ *
+ * version
+ *      Values:         <string>
+ *
+ *      Protocol version, chosen among the ones supported by the backend.
+ *
..snip..
+#define XENDISPL_FIELD_BE_VERSIONS    "versions"
+#define XENDISPL_FIELD_FE_VERSION     "version"
I couldn't find in spec what version this actually is. As in I would
assume it is version 1, but that is not enumerated.
We have:
+ * versions
+ *      Values:         <string>
+ *
+ * List of XENDISPL_LIST_SEPARATOR separated protocol versions supported
+ *      by the backend. For example "1,2,3".
which defines the format of the versions enumeration.
Perhaps it may be good to include in the Backend section that the
'versions' will contain the value 1.
I will probably put something like
#define XENDISPL_PROTOCOL_VERSION "1"
on top, which will particularly used by the backend too:
on top, because this value is not only for backend, but
overall protocol identificator
  And that future changes would
update it?
Thus, once we need to change it we are all set

I will release v5 today with the change above and your comments fixed

Thank you,
Oleksandr

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.