Re: [Xen-devel] [PATCH v2] x86/monitor: add support for descriptor access events

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 04/04/2017 05:57 AM, Adrian Pop wrote:
> Adds monitor support for descriptor access events (reads & writes of
> IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM).
>
> Signed-off-by: Adrian Pop <apop@xxxxxxxxxxxxxxx>


> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -856,6 +856,23 @@ static void svm_set_rdtsc_exiting(struct vcpu *v, bool_t 
> enable)
>      vmcb_set_general2_intercepts(vmcb, general2_intercepts);
>  }
>  
> +static void svm_set_descriptor_access_exiting(struct vcpu *v, bool enable)
> +{
> +    struct vmcb_struct *vmcb = v->arch.hvm_svm.vmcb;
> +    u32 general1_intercepts = vmcb_get_general1_intercepts(vmcb);
> +    u32 mask = GENERAL1_INTERCEPT_IDTR_READ | GENERAL1_INTERCEPT_GDTR_READ \
> +            | GENERAL1_INTERCEPT_LDTR_READ | GENERAL1_INTERCEPT_TR_READ \
> +            | GENERAL1_INTERCEPT_IDTR_WRITE | GENERAL1_INTERCEPT_GDTR_WRITE \
> +            | GENERAL1_INTERCEPT_LDTR_WRITE | GENERAL1_INTERCEPT_TR_WRITE;

I didn't notice this last time --- there is no need for line
continuation here.

With that fixed,

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>eason =
%#"PRIx64", "


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel