Re: [Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 03/04/17 09:40, Wei Liu wrote:
> On Wed, Mar 29, 2017 at 11:27:49AM +0100, Andrew Cooper wrote:
>> On 27/03/17 10:10, Wei Liu wrote:
>>> We will later split out PV specific code to pv/mm.c.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
>> Please could you take the time to correctly mfn_t/gfn_t the calls. 
>> Having both addr and frame, and them being otherwise unqualified, is
>> confusing to read.
>>
> I'm not sure what you want here.
>
> The create_grant_host_mapping function is hooked into grant table code,
> which is using "unsigned long" everywhere.
>
> Modifying it here would require fixing all call sites as well. It'd be
> better be done in a separate patch.

Separate patch is fine, but I purposefully want to avoid moving code
into pv/ and leaving it with style problems.  (i.e. take the time to
ensure the status quo improves).

Fix it then move it, or move it then fix it, but please don't move it
and leave it unfixed.  This covers other areas like bool correctness,
mfn_t/gfn_t, const correctness, comment styles, whitespace, etc.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel