Re: [Xen-devel] [PATCH for 4.9 1/6] x86/hvm: Correct some address space terminology

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 31.03.17 at 21:50, <andrew.cooper3@xxxxxxxxxx> wrote:
> The function hvm_translate_linear_addr() translates a virtual address to a
> linear address, not a linear address to a physical address.  Correct its 
> name.
> 
> Both hvm_translate_virtual_addr() and hvmemul_virtual_to_linear() return a
> linear address, not a physical address.  Correct the parameters name.

I think the "p" in the names didn't stand for "physical", but for
"pointer", and I further think ...

> --- a/xen/arch/x86/hvm/emulate.c
> +++ b/xen/arch/x86/hvm/emulate.c
> @@ -506,7 +506,7 @@ static int hvmemul_virtual_to_linear(
>      unsigned long *reps,
>      enum hvm_access_type access_type,
>      struct hvm_emulate_ctxt *hvmemul_ctxt,
> -    unsigned long *paddr)
> +    unsigned long *linear)

... retaining the "p" here and ...

> --- a/xen/arch/x86/mm/shadow/common.c
> +++ b/xen/arch/x86/mm/shadow/common.c
> @@ -136,13 +136,13 @@ static struct segment_register *hvm_get_seg_reg(
>      return seg_reg;
>  }
>  
> -static int hvm_translate_linear_addr(
> +static int hvm_translate_virtual_addr(
>      enum x86_segment seg,
>      unsigned long offset,
>      unsigned int bytes,
>      enum hvm_access_type access_type,
>      struct sh_emulate_ctxt *sh_ctxt,
> -    unsigned long *paddr)
> +    unsigned long *linear)

... here would be useful (to distinguish the virtual address
represented by the pointer itself - in hypervisor space - from the
one the pointer points to, i.e. in guest space).

With that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel