Re: [Xen-devel] [PATCH] xl: Add 'pvh' config option

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Fri, Mar 31, 2017 at 09:59:09AM -0400, Boris Ostrovsky wrote:
> On 03/31/2017 09:49 AM, Wei Liu wrote:
> > On Fri, Mar 31, 2017 at 09:43:07AM -0400, Boris Ostrovsky wrote:
> >> On 03/31/2017 06:23 AM, Roger Pau Monné wrote:
> >>> On Thu, Mar 30, 2017 at 07:06:15PM -0400, Boris Ostrovsky wrote:
> >>>> In addition to 'device_model_version="none"' config option users can
> >>>> also use 'pvh=1' in xl configuration file when creating a PVH guest.
> >>> I'm not sure, but I think the plan was to remove 
> >>> device_model_version="none"
> >>> and instead just use pvh=1, instead of keeping both. I don't have a strong
> >>> opinion here, so I will leave that to the xl maintainers.
> >> I thought we had PVHv2 in 4.8 but apparently not. I will remove it then.
> >>
> > You can't remove the DM version none just yet.
> >
> > I think Ian has ask for adding a PVH guest type and pvh=1 sets that. It
> > is a bit more work than this patch.
> 
> That would make the toolstack have three guest types while the
> hypervisor has two.
> 
> (Maybe this was already covered but I don't remember seeing this
> discussion).

This was discussed on the PVHv1 removal patches. I sent a PVHv1 removal that
partially covered this (by adding a PVH guest type to libxl), but IMHO I find
it quite hard to add a guest type to libxl only (when it's not on the
hypervisor).

It can certainly be done, but it's painful due to libxl having to filter the
output from Xen in order to properly detect guest types, since it cannot longer
use Xen values blindly.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel