Re: [Xen-devel] [PATCH v6 1/4] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 30 Mar 2017, Jan Beulich wrote:
> >>> On 30.03.17 at 00:18, <sstabellini@xxxxxxxxxx> wrote:
> > +static inline RING_IDX name##_mask(RING_IDX idx, RING_IDX ring_size)       
> >    \
> > +{                                                                          
> >    \
> > +    return (idx & (ring_size - 1));                                        
> >    \
> > +}                                                                          
> >    \
> > +                                                                           
> >    \
> > +static inline unsigned char *name##_get_ring_ptr(unsigned char *buf,       
> >    \
> > +                                                 RING_IDX idx,             
> >    \
> > +                                                 RING_IDX ring_size)       
> >    \
> > +{                                                                          
> >    \
> > +    return buf + name##_mask(idx, ring_size);                              
> >    \
> > +}                                                                          
> >    \
> 
> Inconsistent parenthesization of the operands of return has
> not been taken care of.
> 
> > +struct name##_data {                                                       
> >    \
> > +    unsigned char *in; /* half of the allocation */                        
> >    \
> > +    unsigned char *out; /* half of the allocation */                       
> >    \
> > +};                                                                         
> >    \
> > +
> 
> There's now not only a trailing semicolon here, but also a stray
> backslash.

I'll fix all issues

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel