[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen, kdump: handle pv domain in paddr_vmcoreinfo_note()
>>> On 30.03.17 at 16:18, <jgross@xxxxxxxx> wrote: > @@ -2903,3 +2906,13 @@ int xen_unmap_domain_gfn_range(struct vm_area_struct > *vma, > return -EINVAL; > } > EXPORT_SYMBOL_GPL(xen_unmap_domain_gfn_range); > + > +#ifdef CONFIG_KEXEC_CORE > +phys_addr_t paddr_vmcoreinfo_note(void) > +{ > + if (xen_pv_domain()) > + return virt_to_machine(&vmcoreinfo_note).maddr; > + else > + return __pa((unsigned long)(char *)&vmcoreinfo_note); I don't think you need the double cast here. This being placed in x86 code is correct only as long as the assumption is correct that no other architecture will allow for PV guests. And this being placed in Xen code is correct only as long as the assumption is true that no other hypervisors will allow for PV guests. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |