Re: [Xen-devel] [PATCH v3 7/9] xen/mce: add support of vLMCE injection to XEN_MC_inject_v2

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.03.17 at 08:20, <haozhong.zhang@xxxxxxxxx> wrote:
> @@ -1565,6 +1566,28 @@ long do_mca(XEN_GUEST_HANDLE_PARAM(xen_mc_t) u_xen_mc)
>              }
>              break;
>  
> +        case XEN_MC_INJECT_TYPE_LMCE:
> +            if ( !lmce_support )
> +            {
> +                ret = x86_mcerr("No LMCE support in platform", -EINVAL);

Please drop "in platform".

> +                break;
> +            }
> +            if ( broadcast )
> +            {
> +                ret = x86_mcerr("XEN_MC_INJECT_CPU_BROADCAST cannot be used "
> +                                "with XEN_MC_INJECT_TYPE_LMCE",

Please shorten this by dropping the symbolic prefixes. Perhaps simply
"Broadcast cannot be used with LMCE"?

> +                                -EINVAL);
> +                break;
> +            }
> +            /* Ensure at most one CPU is specified. */
> +            if ( nr_cpu_ids > cpumask_next(cpumask_first(cpumap), cpumap) )
> +            {
> +                ret = x86_mcerr("More than one CPU specified", -EINVAL);

"... for LMCE"

With that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel