Re: [Xen-devel] [PATCH v3 5/9] x86/vmce: enable injecting LMCE to guest on Intel host

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 30.03.17 at 08:19, <haozhong.zhang@xxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/mcheck/mcaction.c
> +++ b/xen/arch/x86/cpu/mcheck/mcaction.c
> @@ -44,6 +44,7 @@ mc_memerr_dhandler(struct mca_binfo *binfo,
>      unsigned long mfn, gfn;
>      uint32_t status;
>      int vmce_vcpuid;
> +    uint16_t mc_vcpuid;

Any reason this can't be plain unsigned int? Nowadays we try to
stay away from fixed width types where they aren't really needed.

> --- a/xen/arch/x86/cpu/mcheck/vmce.c
> +++ b/xen/arch/x86/cpu/mcheck/vmce.c
> @@ -464,14 +464,23 @@ static int vcpu_fill_mc_msrs(struct vcpu *v, uint64_t 
> mcg_status,
>  }
>  
>  int fill_vmsr_data(struct mcinfo_bank *mc_bank, struct domain *d,
> -                   uint64_t gstatus, bool broadcast)
> +                   uint64_t gstatus, int vmce_vcpuid)
>  {
>      struct vcpu *v = d->vcpu[0];
> +    bool broadcast = (vmce_vcpuid == VMCE_INJECT_BROADCAST);
>      int ret, err;
>  
>      if ( mc_bank->mc_domid == DOMID_INVALID )
>          return -EINVAL;
>  
> +    if ( broadcast )
> +        gstatus &= ~MCG_STATUS_LMCE;
> +    else if ( gstatus & MCG_STATUS_LMCE )
> +    {
> +        ASSERT(vmce_vcpuid >=0 && vmce_vcpuid < d->max_vcpus);

Missing blank.

With these taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel