Re: [Xen-devel] [PATCH v2 for-4.9] x86/mm: Drop MEM_LOG() and correct some printed information

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.03.17 at 17:38, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -1388,7 +1398,7 @@ static int alloc_l1_table(struct page_info *page)
>      return 0;
>  
>   fail:
> -    MEM_LOG("Failure in alloc_l1_table: entry %d", i);
> +    gdprintk(XENLOG_WARNING, "Failure in alloc_l1_table: slot %#x\n", i);

Switching to slot (in hex) here vs ...

> @@ -1464,7 +1474,7 @@ static int alloc_l2_table(struct page_info *page, 
> unsigned long type,
>  
>          if ( rc < 0 )
>          {
> -            MEM_LOG("Failure in alloc_l2_table: entry %d", i);
> +            gdprintk(XENLOG_WARNING, "Failure in alloc_l2_table: entry 
> %d\n", i);

... staying with entry (in dec) here (and further down)?

> @@ -3917,7 +3942,7 @@ long do_mmu_update(
>              break;
>  
>          default:
> -            MEM_LOG("Invalid page update command %x", cmd);
> +            gdprintk(XENLOG_WARNING, "Invalid page update command %#x\n", 
> cmd);

You delete the respective mmuext message - please do so here too.

> @@ -4071,8 +4096,9 @@ static int destroy_grant_pte_mapping(
>      if ( unlikely(l1e_get_pfn(ol1e) != frame) )
>      {
>          page_unlock(page);
> -        MEM_LOG("PTE entry %lx for address %"PRIx64" doesn't match frame 
> %lx",
> -                (unsigned long)l1e_get_intpte(ol1e), addr, frame);
> +        gdprintk(XENLOG_WARNING,
> +                 "PTE entry %lx for address %"PRIx64" doesn't match frame 
> %lx\n",
> +                 (unsigned long)l1e_get_intpte(ol1e), addr, frame);

PRIpte and the cast dropped?

With these taken care of
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel