Re: [Xen-devel] [PATCH for-4.9] xen/arm: acpi: Map MMIO on fault in stage-2 page table for the hardware domain

[Julien Grall <julien.grall@xxxxxxx>]

On 30/03/17 13:52, Shanker Donthineni wrote:
> Hi Julien,

Hi Shanker,

> On 03/30/2017 07:43 AM, Julien Grall wrote:
>>     Shanker: You mentioned offline that you tested the patch. May I add
>>     your tested-by?
> 
> Sure add my tested-by. If you want I can test one more time this mailing list 
> patch.

The code is the same, but it would not hurt to have another go at it :).

FWIW, I did some testing on Juno with a small patch to turn the mapping
hypercall into a nop and adding a debug message when mapping:


diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 626376090d..dd1b0bd2b2 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1116,6 +1116,8 @@ int map_dev_mmio_region(struct domain *d,
 {
     int res;
 
+    return 0;
+
     if ( !(nr && iomem_access_permitted(d, mfn_x(mfn), mfn_x(mfn) + nr - 1)) )
         return 0;
 
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index ebf915bb3b..9e6d2dafc8 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -2643,7 +2643,11 @@ static void do_trap_data_abort_guest(struct 
cpu_user_regs *regs,
             return;
 
         if ( try_map_mmio(_gfn(paddr_to_pfn(info.gpa))) )
+        {
+            gdprintk(XENLOG_DEBUG, "Map %#"PRIpaddr" - %#"PRIpaddr"\n",
+                     info.gpa, info.gpa + PAGE_SIZE - 1);
             return;
+        }
 
         break;
     default:

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel