Re: [Xen-devel] [PATCH RFC 03/13] x86/mm: export vcpumask_to_pcpumask

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Mar 29, 2017 at 11:15:18AM +0100, Andrew Cooper wrote:
> On 27/03/17 10:10, Wei Liu wrote:
> > Prefix it with "mm_". No functional change.
> >
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > ---
> > It used to be a inline function, but I don't think there is no point in
> 
> Double negative.  "think there is any point" ?
> 

Right. That's that I meant.

> mmuext_op was added to HVM guests in c/s 2204b1ce06ac for PVHv1. 
> However, everything in it is PV specific, so I think it is reasonable to
> make its reference in the HVM hypercall table conditional on CONFIG_PV,
> and for it to move fully into pv/mm.c
> 

I am certainly fine with this.

> At that point, this function can move as well.
> 
> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel