Re: [Xen-devel] [PATCH RFC 04/13] x86/mm: carve out create_grant_pv_mapping

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/03/17 10:10, Wei Liu wrote:
> We will later split out PV specific code to pv/mm.c.
>
> No functional change.
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Please could you take the time to correctly mfn_t/gfn_t the calls. 
Having both addr and frame, and them being otherwise unqualified, is
confusing to read.

One idea I had while starting the hypercall work was to introduce a
"struct guest_type_ops" to contain some function pointers for options we
perform on all guests, irrespective of type.  My first candidate for
splitting this way was the hypercall page writing.

This splitting here is subtly different.  Its more "struct
paging_type_op", but still common operations we would need to perform
for guests.

I was thinking that ops structures like this would be cleaner to isolate
than needing an explicit dispatch functions such as
create_grant_host_mapping() below.

Thoughts, (seeing as this is the first time I have floated this idea on
xen-devel) ?

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel