Re: [Xen-devel] [PATCH v4 1/4] ring.h: introduce macros to handle monodirectional rings with multiple req sizes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.03.17 at 23:07, <sstabellini@xxxxxxxxxx> wrote:
> On Tue, 28 Mar 2017, Jan Beulich wrote:
>> >>> Stefano Stabellini <sstabellini@xxxxxxxxxx> 03/27/17 10:53 PM >>>
>> >On Mon, 27 Mar 2017, Jan Beulich wrote:
>> >> >>> On 24.03.17 at 19:31, <sstabellini@xxxxxxxxxx> wrote:
>> >> > +#ifndef PAGE_SHIFT
>> >> > +#define PAGE_SHIFT 12
>> >> > +#endif
>> >> 
>> >> ??? (I guess this should be another prereq?)
>> >
>> >Yes, the PAGE_SHIFT definition could be a prereq, but I thought that
>> >these 3 lines are small enough that they would be harmless. I am happy
>> >to make it a prereq though, I'll remove it.
>> 
>> The problem isn't size or anything, but the risk to clash with a _later_ 
>> definition
>> (due to a subsequent #include). The name, after all, isn't in the XEN_ name 
>> space.
>  
> Yes, you are right, and as I replied afterward we cannot rely on the
> PAGE_SHIFT set by the system anyway. If that's OK I'll define
> XEN_PAGE_SHIFT instead.

That should be fine, I think.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel