Re: [Xen-devel] [PATCH RFC 01/13] x86/mm: export {get, put}_pg_owner

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 27/03/2017 10:10, Wei Liu wrote:
> Prefix them with "mm_" and add declarations to asm-x86/mm.h.
>
> They will be needed when we split PV specific code out of x86/mm.c.
>
> No functional change.
>
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

I have to admit that I don't understand why they are called
{get,put}_pg_owner.  Perhaps very historical from Linux?

They are nothing to do with pages, and get a reference on the domain.

I'd recommend s/pg_owner/domain/ so the function calls actually indicate
what object is having the reference taken on it.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel