[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v9 12/25] x86: refactor psr: L3 CAT: set value: implement cos id picking flow.
- To: "Yi Sun" <yi.y.sun@xxxxxxxxxxxxxxx>
- From: "Jan Beulich" <JBeulich@xxxxxxxx>
- Date: Tue, 28 Mar 2017 06:20:48 -0600
- Cc: kevin.tian@xxxxxxxxx, wei.liu2@xxxxxxxxxx, he.chen@xxxxxxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, dario.faggioli@xxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, mengxu@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, chao.p.peng@xxxxxxxxxxxxxxx, roger.pau@xxxxxxxxxx
- Delivery-date: Tue, 28 Mar 2017 12:21:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
>>> On 28.03.17 at 13:59, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> I think we at least need a 'get_val()' hook.
Of course.
> I try to implement CAT/CDP hook.
> Please help to check if this is what you thought.
One remark below, but other than that - yes.
> static void cat_get_val(const struct feat_node *feat, unsigned int cos,
> enum cbm_type type, int flag, uint32_t *val)
> {
> *val = feat->cos_reg_val[cos];
> }
>
> static void l3_cdp_get_val(const struct feat_node *feat, unsigned int cos,
> enum cbm_type type, int flag, uint32_t *val)
> {
> if ( type == PSR_CBM_TYPE_L3_DATA || flag == 0 )
> *val = get_cdp_data(feat, cos);
> if ( type == PSR_CBM_TYPE_L3_CODE || flag == 1 )
> *val = get_cdp_code(feat, cos);
> }
Why the redundancy between type and flag?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel
|
