Re: [Xen-devel] [PATCH v4 2/4] xen: introduce a C99 headers check

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Stefano Stabellini <sstabellini@xxxxxxxxxx> 03/27/17 10:50 PM >>>
>On Mon, 27 Mar 2017, Jan Beulich wrote:
>> >>> On 24.03.17 at 19:31, <sstabellini@xxxxxxxxxx> wrote:
>> > Introduce a C99 headers check, for non-ANSI compliant headers. No
>> > headers are added to the check yet.
>> > 
>> > In addition to the usual -include stdint.h, also add -include string.h
>> > to the C99 check to get the declaration of memcpy and size_t.
>> 
>> Is this really needed for the check to succeed, without there being
>> any user of the macros?
>
>The check is unneeded, but the two following patches are going to add
>two new users of these macros. The check will be needed then. I'll move
>the patch to the end of the series.

We shouldn't enforce this extra inclusion on all headers, i.e. I think you'll
need to introduce per-header prereqs to be enforced via -include.

> > For the same reasons, also add -include string.h to the C++ check.
> 
> Same here then.

One more thing here - if at all, this perhaps would need to be cstring instead
of string.h.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel