Re: [Xen-devel] [PATCH v9 17/25] x86: refactor psr: CDP: implement set value callback functions.

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-03-27 08:17:04, Jan Beulich wrote:
> >>> On 16.03.17 at 12:08, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> > +static bool l3_cdp_fits_cos_max(const uint32_t val[],
> > +                                const struct feat_node *feat,
> > +                                unsigned int cos)
> > +{
> > +    if ( cos > feat->info.cat_info.cos_max &&
> > +         (val[0] != get_cdp_data(feat, 0) || val[1] != get_cdp_code(feat, 
> > 0)) )
> > +            /*
> > +             * Exceed cos_max and value to set is not default,
> > +             * return error.
> > +             */
> > +            return false;
> 
> Indentation. But presumably this function will go away anyway.
> 
As explanation in previous patch, this CDP callback function is different
with CAT. So, I am afraid we have to keep it.

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel