Re: [Xen-devel] [PATCH v3] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP

[Julien Grall <julien.grall@xxxxxxx>]

Hello Vijay,

I agree with Jan's comments.

On 27/03/17 08:10, vijay.kilari@xxxxxxxxx wrote:

> diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
[...]

> diff --git a/xen/include/asm-x86/page.h b/xen/include/asm-x86/page.h
I am not sure to understand why the helper is added in mm.h for ARM but 
page.h for x86.
The purpose of architecture headers is to always include the same header 
name and retrieve the correct implementation without adding #ifdef in 
the common code.
In this case, I think it would make sense to always use mm.h.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel