Re: [Xen-devel] [PATCH 02/10] x86/emul: Add feature check for clzero

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.03.17 at 14:13, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 27/03/17 12:28, Jan Beulich wrote:
>>>>> On 27.03.17 at 11:56, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> @@ -5183,6 +5184,8 @@ x86_emulate(
>>>          {
>>>              unsigned long zero = 0;
>>>  
>>> +            vcpu_must_have(clzero);
>> Hmm, wait - doesn't this break the test harness? I.e. don't you need
>> to also adjust emul_test_cpuid()?
> 
> The logical chain of events which lead to this discovery was an
> assertion failure in the stos() hook, and wondering how I hit it fuzzing
> on an Intel machine.
> 
> The emul_test_cpuid() adjustment is later in the series with other
> related changes.

I don't think I've seen CLZERO there, but the (initial) adjustment
would belong here anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel