Re: [Xen-devel] [PATCH] tools/libxenforeignmemory: add a call to restrict the handle

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 22/03/17 11:25, Paul Durrant wrote:
> diff --git a/tools/libs/foreignmemory/libxenforeignmemory.map 
> b/tools/libs/foreignmemory/libxenforeignmemory.map
> index df206b3..5c9806c 100644
> --- a/tools/libs/foreignmemory/libxenforeignmemory.map
> +++ b/tools/libs/foreignmemory/libxenforeignmemory.map
> @@ -4,5 +4,6 @@ VERS_1.0 {
>               xenforeignmemory_close;
>               xenforeignmemory_map;
>               xenforeignmemory_unmap;
> +             xenforeignmemory_restrict;
>       local: *; /* Do not expose anything by default */
>  };

This isn't correct.

New functions like this need to bump at least the SO minor version, like
c/s f1446de4ba

Fixing this is a blocker to releasing 4.9

Also, we should really get automatic ABI checking built into the release
process, to prevent mistakes like this from happening accidentally.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel