[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 0/2] libxl: add PV display device driver interface
On 23/03/17 11:10, Oleksandr Grytsov wrote: > From: Oleksandr Grytsov <oleksandr_grytsov@xxxxxxxx> > > Hi all, > > We are working on series of PV drivers (display, sound, input etc.) and > would like to add their support to libxl and xl. These patches add PV display > device. PV display is based on [1] protocol. > > During implementation I see a lot of code duplication. This problem was > mentioned in [2]. One of the solutions was to implement common parts in IDL > and make them autogenerated. On my side, to minimize the copy/pasting > I've moved common parts into macro functions: LIBXL_DEFINE_DEVICE_COMMIT, > LIBXL_DEFINE_DEVICE_LIST_GET, LIBXL_DEFINE_DEVICE_GETINFO etc. > Existing PV devices implementations can be reworked to use these macros as > well. Any other proposals to avoid the duplications are welcome. Did you look into the device type framework I introduced with commit 74e857c6c7f9 and some followups? Maybe it is possible to expand this framework by adding more callbacks to struct libxl_device_type and have some common function(s) in libxl_device.c? Juergen _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |