Re: [Xen-devel] [PATCH 3/3] xen/x86: support larger memory map from EFI

[Juergen Gross <jgross@xxxxxxxx>]

On 22/03/17 14:19, Jan Beulich wrote:
>>>> On 21.03.17 at 14:10, <jgross@xxxxxxxx> wrote:
>> Use a larger e820 map buffer for non-BIOS memory map sources. This
>> requires to have different defines for the maximum number of E820 map
>> entries for the raw BIOS buffer and the later used struct e820map.
>>
>> While at it use e820.h in mem.S in order to avoid having to define the
>> buffer size at two places.
> 
> I don't think you need to define it outside the assembly file at all,
> since the use in setup.c seems unnecessary (instead you rather
> want to keep E820MAX [or its ARRAY_SIZE() equivalent] there as
> the output array bound; the input value can't exceed
> E280_BIOS_MAX anyway). One reason to actually have the #define
> in the header would be if you used it in the e820map[] declaration,
> but since that array is bounded by e820nr I don't think that's
> strictly necessary.

Even more obvious with e820map[] visibility restricted to assembly code.

So I will just replace E820MAX with E820_BIOS_MAX in assembly without
adding E820_BIOS_MAX to e820.h.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel