Re: [Xen-devel] [PATCH] x86/hvm: switch some open-coded dpci access to use the provided macro

[Roger Pau Monne <roger.pau@xxxxxxxxxx>]

On Tue, Mar 21, 2017 at 10:33:26AM -0600, Jan Beulich wrote:
> >>> On 21.03.17 at 16:41, <roger.pau@xxxxxxxxxx> wrote:
> > No functional change.
> 
> The reason it's done the original way is, I guess, that - other than
> your title suggests - this is not a macro, and not even an inline
> function. In cases where the two checks the function does aren't
> needed, I think it is reasonable to avoid the call.

Right, seems like I got confused with another helper. Would you like me to make
that an inline function, or just leave it as-is?

The function includes an extra is_hvm_domain check, so I guess it's better to
leave it as-is for those paths.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel