Re: [Xen-devel] [PATCH v3 6/6] x86/viridian: implement the crash MSRs

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 22 March 2017 11:38
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; Ian Jackson
> <Ian.Jackson@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH v3 6/6] x86/viridian: implement the crash
> MSRs
> 
> >>> On 21.03.17 at 19:17, <paul.durrant@xxxxxxxxxx> wrote:
> > +    case HV_X64_MSR_CRASH_CTL:
> > +    {
> > +        HV_CRASH_CTL_REG_CONTENTS ctl = {
> > +            .CrashNotify = 1,
> > +        };
> 
> This initializer failed my pre-push build test: Some gcc versions we
> still support don't allow fields of unnamed union members to be
> initialized this way. As there are at least two ways to deal with
> this, and as this is code maintained by you, I didn't want to pick
> either, as I don't know your preference.
> 

Ok, I guess I'll go for naming the union member. Do you want me to resubmit?

  Paul 

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel