Re: [Xen-devel] [PATCH v1 1/5] xen/libcx/tmem: Replace TMEM_RESTORE_NEW with XEN_SYSCTL_TMEM_OP_SET_POOLS

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Mar 19, 2017 at 09:41:08AM -0400, Konrad Rzeszutek Wilk wrote:
> diff --git a/tools/libxc/xc_tmem.c b/tools/libxc/xc_tmem.c
> index 51d11ef..181de48 100644
> --- a/tools/libxc/xc_tmem.c
> +++ b/tools/libxc/xc_tmem.c
> @@ -385,16 +385,18 @@ static int xc_tmem_restore_new_pool(
>                      uint64_t uuid_lo,
>                      uint64_t uuid_hi)
>  {
> -    tmem_op_t op;
> -
> -    op.cmd = TMEM_RESTORE_NEW;
> -    op.pool_id = pool_id;
> -    op.u.creat.arg1 = cli_id;
> -    op.u.creat.flags = flags;
> -    op.u.creat.uuid[0] = uuid_lo;
> -    op.u.creat.uuid[1] = uuid_hi;
> -
> -    return do_tmem_op(xch, &op);
> +    xen_tmem_pool_info_t pool = {
> +        .flags.raw = flags,
> +        .id = pool_id,
> +        .n_pages = 0,
> +        .uuid[0] = uuid_lo,
> +        .uuid[1] = uuid_hi,
> +    };
> +
> +    return xc_tmem_control(xch, pool_id,
> +                           XEN_SYSCTL_TMEM_OP_SET_POOLS,
> +                           cli_id, sizeof(pool),
> +                           0 /* arg */, &pool);
>  }

This bit looks sensible:

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel