Re: [Xen-devel] [PATCH v2 6/6] x86/viridian: implement the crash MSRs

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.03.17 at 18:08, <paul.durrant@xxxxxxxxxx> wrote:
> @@ -619,6 +636,36 @@ int wrmsr_viridian_regs(uint32_t idx, uint64_t val)
>              update_reference_tsc(d, 1);
>          break;
>  
> +    case HV_X64_MSR_CRASH_P0:
> +    case HV_X64_MSR_CRASH_P1:
> +    case HV_X64_MSR_CRASH_P2:
> +    case HV_X64_MSR_CRASH_P3:
> +    case HV_X64_MSR_CRASH_P4:
> +        BUILD_BUG_ON(HV_X64_MSR_CRASH_P4 - HV_X64_MSR_CRASH_P0 >=
> +                     ARRAY_SIZE(v->arch.hvm_vcpu.viridian.crash_param));
> +
> +        idx -= HV_X64_MSR_CRASH_P0;
> +        v->arch.hvm_vcpu.viridian.crash_param[idx] = val;
> +        break;
> +
> +    case HV_X64_MSR_CRASH_CTL:
> +    {
> +        HV_CRASH_CTL_REG_CONTENTS ctl;
> +
> +        ctl.AsUINT64 = val;
> +
> +        if ( !ctl.CrashNotify )
> +            break;
> +
> +        gprintk(XENLOG_INFO, "VIRIDIAN CRASH: %lx %lx %lx %lx %lx\n",
> +                v->arch.hvm_vcpu.viridian.crash_param[0],
> +                v->arch.hvm_vcpu.viridian.crash_param[1],
> +                v->arch.hvm_vcpu.viridian.crash_param[2],
> +                v->arch.hvm_vcpu.viridian.crash_param[3],
> +                v->arch.hvm_vcpu.viridian.crash_param[4]);

With default log level settings this message will go nowhere. If that's
intended, I don't mind, but I think XENLOG_WARNING (or simply no
log level) would be better here.

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Let me know whether you want me to make the adjustment while
committing.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel