Re: [Xen-devel] [PATCH v2 5/6] x86/viridian: make the threshold for HvNotifyLongSpinWait tunable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.03.17 at 18:08, <paul.durrant@xxxxxxxxxx> wrote:
> The current threshold before the guest issues the hypercall is, and always
> has been, hard-coded to 2047. It is not clear where this number came
> from so, to at least allow for ease of experimentation, this patch makes
> the threshold tunable via the Xen command line.
> 
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

albeit ...

> --- a/docs/misc/xen-command-line.markdown
> +++ b/docs/misc/xen-command-line.markdown
> @@ -1637,6 +1637,14 @@ The hypervisor minor version number encoded in CPUID 
> 0x40000002:EBX.
>  
>  The hypervisor build number encoded in CPUID 0x40000002:EAX.
>  
> +### viridian\_spinlock\_retry\_count

... I'd prefer if dashes instead of underscores were used:
Command line options don't need to be identifiers, and dashes
are easier to type (not requiring the shift key).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel