Re: [Xen-devel] [PATCH v2 1/6] x86/viridian: fix xen-hvmcrash when vp_assist page is present

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 21 March 2017 15:27
> To: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; xen-
> devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 1/6] x86/viridian: fix xen-hvmcrash when vp_assist
> page is present
> 
> >>> On 20.03.17 at 18:08, <paul.durrant@xxxxxxxxxx> wrote:
> > Currently use of xen-hvmcrash will cause an immediate domain_crash() in
> > initialize_vp_assist() because it is called from viridian_load_vcpu_ctxt()
> > without having first cleared any previous mapping.
> >
> > This patch addes a check into viridian_load_vcpu_ctxt() to avoid re-
> > initialization and turned the domain_crash() in initialize_vp_assist()
> > into an ASSERT() since neither codepath into that function should allow
> > it to be hit.
> 
> The patch looks fine to me, but not in line with the description:
> There's no domain_crash() being eliminated anymore.

Oh. That hunk must have been dropped for some reason. It should be there. I'll 
send v3.

  Paul

> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel