Re: [Xen-devel] [PATCH v8] xen: Allow a default compiled-in command line using Kconfig

[Zhongze Liu <blackskygg@xxxxxxxxx>]

2017-03-21 22:27 GMT+08:00 Jan Beulich <JBeulich@xxxxxxxx>:
>>>> On 21.03.17 at 12:18, <blackskygg@xxxxxxxxx> wrote:
>> --- a/xen/common/Kconfig
>> +++ b/xen/common/Kconfig
>> @@ -237,4 +237,26 @@ config FAST_SYMBOL_LOOKUP
>>         The only user of this is Live patching.
>>
>>         If unsure, say Y.
>> +
>> +config CMDLINE
>> +     string "Built-in hypervisor command string"
>> +     default ""
>> +     depends on EXPERT = "y"
>
> Luckily I've noticed the non-EXPERT build failure in my pre-push
> tests: During review of patch 3 I had asked for converting the
> "depends on" into a conditional prompt, and I don't see why
> this wasn't done. Did you ever do a non-EXPERT build with your
> patch?
>
Yes, I've built and tested my patch with and without XEN_CONFIG_EXPERT=y.
Could you please show me the error message?

BTW, my environment:
uname -a:
    Linux sky-arch 4.10.2-1-ARCH #1 SMP PREEMPT Mon Mar 13 17:13:41
CET 2017 x86_64 GNU/Linux

gcc -v
    Using built-in specs.
    COLLECT_GCC=gcc
    COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-pc-linux-gnu/6.3.1/lto-wrapper
    Target: x86_64-pc-linux-gnu
    Configured with: /build/gcc/src/gcc/configure --prefix=/usr
--libdir=/usr/lib --libexecdir=/usr/lib --mandir=/usr/share/man
--infodir=/usr/share/info --with-bugurl=https://bugs.archlinux.org/
--enable-
languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared
--enable-threads=posix --enable-libmpx --with-system-zlib --with-isl
--enable-__cxa_atexit --disable-libunwind-exceptions
--enable-clocale=gnu --disable-libstdcxx-pch --disable-libssp
--enable-gnu-unique-object --enable-linker-build-id --enable-lto
--enable-plugin --enable-install-libiberty
--with-linker-hash-style=gnu --enable-gnu-indirect-function
--disable-multilib --disable-werror --enable-checking=release
Thread model: posix
    gcc version 6.3.1 20170306 (GCC)

I used x86_64-w64-mingw32 binutils to build the EFI stub.
and the configuration:
   ./configure \
    PYTHON=/usr/bin/python2 \
    --prefix=/usr \
    --sbindir=/usr/bin \
    --with-sysconfig-leaf-dir=conf.d \
    --with-initddir=/etc/init.d \
    --enable-systemd \
    --disable-docs \
    --disable-stubdom \
    --with-extra-qemuu-configure-args="--disable-bluez --disable-gtk
--enable-spice --enable-usb-redir";

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel