Re: [Xen-devel] [PATCH v2 02/10] x86: assembly, FUNC_START for fn, DATA_START for data

[Pavel Machek <pavel@xxxxxx>]

Hi!

> -ENTRY(saved_rbp)     .quad   0
> -ENTRY(saved_rsi)     .quad   0
> -ENTRY(saved_rdi)     .quad   0
> -ENTRY(saved_rbx)     .quad   0
> +SYM_DATA_START(saved_rbp)            .quad   0
> +SYM_DATA_START(saved_rsi)            .quad   0
> +SYM_DATA_START(saved_rdi)            .quad   0
> +SYM_DATA_START(saved_rbx)            .quad   0

Does it make sense to call it SYM_DATA_*START* when there's no
corresponding end?

Plus... it looks like saved_rsi (and friends) are only used inside
wakeup_64.S. Could we just delete the "ENTRY" annotations?

Thanks,
                                                                Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel