Re: [Xen-devel] [PATCH v2 2/4] x86: split PV dom0 builder to pv/dom0_builder.c

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.03.17 at 18:54, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -154,11 +155,11 @@ static void __init parse_dom0_nodes(const char *s)
>  }
>  custom_param("dom0_nodes", parse_dom0_nodes);
>  
> -static cpumask_t __initdata dom0_cpus;
> +cpumask_t __initdata dom0_cpus;

I'd prefer if this variable remained static, and I think this is doable:

> -static struct vcpu *__init setup_dom0_vcpu(struct domain *d,
> -                                           unsigned int vcpu_id,
> -                                           unsigned int cpu)
> +struct vcpu *__init dom0_setup_vcpu(struct domain *d,
> +                                    unsigned int vcpu_id,
> +                                    unsigned int cpu)
>  {

It's needed only by the callers of this function afaics, and the
cpumask_first() / cpumask_cycle() invocations could easily move
into the function, with the callers updating their "cpu" variables
from v->processor (with v assumed to be a variable to store the
return value of the function, and checked to be non-NULL).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel