Re: [Xen-devel] [PATCH v2 08/17] tools: provide pkg-config file for libxengnttab

[Juergen Gross <jgross@xxxxxxxx>]

On 14/03/17 21:06, Andrew Cooper wrote:
> On 14/03/17 13:31, Juergen Gross wrote:
>> In order to be able to use pkg-config for obtaining linker- and
>> compiler-flags provide a xengnttab.pc and a xengntshr.pc file.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> 
> What is xengntshr.pc actually for?

I just followed the existing coding. In tools/Rules.mk there are gntshr
specific flags, so I provided the related pkg-config file.

I have no problems with eliminating all gntshr references.

> (I am forward porting the XenServer patch queue, and rpm informs me that
> there is no real libxengntshr)
> 
> All gntshr functionality is inside gnttab, and only a single shared
> object exists.
> 
> In fact, I can't see why we have any *_libxengntshr infrastructure at
> all (c/s a71ad0feada which introduced it originally doesn't help; they
> weren't two libraries before either...).
> 
> The two uses of *_libxengntshr infrastructure are libxc and libvchan,
> both of which reference *_libxengnttab immediately before.

In other words: You'd like gntshr to be removed, right?

I think I'll just post a patch. This will be either accepted or not.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel