Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

[Vlad-Ioan TOPAN <itopan@xxxxxxxxxxxxxxx>]

> > +struct vm_event_desc_access {
> > +    union {
> > +        uint32_t vmx_instr_info;    /* VMX: VMCS Instruction-Information 
> > Field */
> > +        uint64_t svm_exitinfo;      /* SVM: VMCB EXITINFO Field */
> > +        uint64_t info;
> > +    } vmexit;
> > +    uint64_t exit_qualification;    /* VMX only: VMCS Exit Qualification 
> > Field */
> 
> IMHO it might be a bit cleaner if we had two sub-structs here, one for
> vmx and one for svm, and have them in a union. The vmx struct would
> have vmx_instr_info and exit_qualification, while the svm would only
> have svm_exitinfo.

Makes sense, will do.

--
Vlad-Ioan TOPAN
Linux Kernel Development Lead
Bitdefender

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel