Re: [Xen-devel] [PATCH] tools: include sys/sysmacros.h on Linux

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Mar 14, 2017 at 11:43:09AM +0000, Wei Liu wrote:
> On Tue, Mar 14, 2017 at 07:37:04AM +0000, Olaf Hering wrote:
> > Due to a bug in the glibc headers the macros makedev(), major() and
> > minor() where avaialble by including sys/types.h. This bug was
> > addressed in glibc-2.25 by introducing a warning when these macros are
> > used. Since Xen is build with -Werror this new warning cause a compile
> > error.
> > 
> > Use sys/sysmacros.h to define these three macros.
> > 
> > blktap2 is already Linux specific. The kernel header which was used to
> > get makedev() does not provided it anymore, and it was wrong to use a
> > kernel header anyway.
> > 
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> 
> Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Got this while compiling on Debian Stretch:

tap-ctl-allocate.c: In function ‘tap_ctl_check_environment’:
tap-ctl-allocate.c:143:9: error: ‘MISC_MAJOR’ undeclared (first use in
this function)
         MISC_MAJOR,
         ^~~~~~~~~~
tap-ctl-allocate.c:143:9: note: each undeclared identifier is reported
only once for each 
function it appears in
/local/work/COMMITTER/xen.git/tools/blktap2/control/../../..//tools/Rules.mk:212:
recipe f
or target 'tap-ctl-allocate.opic' failed
make[5]: *** [tap-ctl-allocate.opic] Error 1

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel