Re: [Xen-devel] [PATCH v8 06/24] x86: refactor psr: implement get hw info flow.

[Yi Sun <yi.y.sun@xxxxxxxxxxxxxxx>]

On 17-03-10 01:57:57, Jan Beulich wrote:
> >>> On 10.03.17 at 02:43, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> > On 17-03-08 08:15:33, Jan Beulich wrote:
> >> >>> On 15.02.17 at 09:49, <yi.y.sun@xxxxxxxxxxxxxxx> wrote:
> >> > --- a/xen/arch/x86/psr.c
> >> > +++ b/xen/arch/x86/psr.c
> >> > @@ -84,6 +84,7 @@ enum psr_feat_type {
> >> >      PSR_SOCKET_L3_CAT = 0,
> >> >      PSR_SOCKET_L3_CDP,
> >> >      PSR_SOCKET_L2_CAT,
> >> > +    PSR_SOCKET_UNKNOWN = 0xFFFF,
> >> 
> >> Any reason to use this value, instead of just the next sequential one?
> >> 
> > This is an error value used below, in 'psr_cbm_type_to_feat_type'. To make 
> > it
> > explicitly different, I assign a big value to it.
> 
> How does that "big value" help?
> 
It is just my habit. I will remove this assignment if you don't like it.

> Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel