Re: [Xen-devel] [PATCH v2 4/6] iommu: Remove dependency on __LINE__ for release builds

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.03.17 at 18:46, <ross.lagerwall@xxxxxxxxxx> wrote:

When seeing the title I wondered by I didn't get Cc-ed. Perhaps the
prefix would better have been VT-d: ?

> --- a/xen/drivers/passthrough/vtd/dmar.h
> +++ b/xen/drivers/passthrough/vtd/dmar.h
> @@ -108,6 +108,19 @@ struct acpi_atsr_unit 
> *acpi_find_matched_atsr_unit(const struct pci_dev *);
>  
>  #define DMAR_OPERATION_TIMEOUT MILLISECS(1000)
>  
> +#if defined(NDEBUG) && defined(CONFIG_LIVEPATCH)
> +#define iommu_wait_op_panic()                                              \
> +    do {                                                                   \
> +        panic("%pS: DMAR hardware is malfunctional", current_text_addr()); \
> +    } while (0)
> +#else
> +#define iommu_wait_op_panic()                                              \
> +    do {                                                                   \
> +        panic("%s:%d:%s: DMAR hardware is malfunctional",                  \
> +              __FILE__, __LINE__, __func__);                               \

If you touch this already, may I suggest eliminating the redundancy
here: Either file or function name should suffice to uniquely identify
the origin.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel