[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] xen: credit2: remove undefined static function __dump_execstate().
On Thu, 2017-03-09 at 03:09 -0700, Jan Beulich wrote: > > > > On 09.03.17 at 10:54, <dario.faggioli@xxxxxxxxxx> wrote: > > > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -2437,8 +2437,6 @@ csched2_runtime(const struct scheduler *ops, > > int cpu, > > return time; > > } > > > > -void __dump_execstate(void *unused); > > All fine, except the function wasn't static (or else the compiler > would > have warned about there not being a definition), so perhaps the > subject wants to say "undefined function declaration" or some such. > Right, of course it's not... sorry. What I was aiming was to somehow reinforce the fact that it's only present in this file, but that's not really necessary, and 'static' was very wrong a word for that. I'd be fine with a subject line like: "xen: credit: remove undefined declaration of __dump_execstate()" Let me know if you or George prefer that I resend, or to adjust this upon commit. Or just ignore this mail, and if I don't hear anything for a while, I will just resend. :-) Thanks, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) Attachment:
signature.asc _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx https://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |