Re: [Xen-devel] [PATCH 1/3] x86emul: switch away from temporary 32-bit register names

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 07/03/17 16:42, Jan Beulich wrote:
> @@ -3266,36 +3266,36 @@ x86_emulate(
>      case 0x27: /* daa */
>      case 0x2f: /* das */ {
>          uint8_t al = _regs.al;
> -        unsigned int eflags = _regs._eflags;
> +        unsigned int eflags = _regs.eflags;
>  
> -        _regs._eflags &= ~(X86_EFLAGS_CF | X86_EFLAGS_AF | X86_EFLAGS_SF |
> +        _regs.eflags &= ~(X86_EFLAGS_CF | X86_EFLAGS_AF | X86_EFLAGS_SF |
>                             X86_EFLAGS_ZF | X86_EFLAGS_PF);

This line needs indenting accordingly.

> @@ -6395,20 +6395,20 @@ x86_emulate(
>                     ((dst.orig_val << shift) |
>                      ((src.val >> (width - shift)) & ((1ull << shift) - 1))));
>          dst.val = truncate_word(dst.val, dst.bytes);
> -        _regs._eflags &= ~(X86_EFLAGS_OF | X86_EFLAGS_SF | X86_EFLAGS_ZF |
> +        _regs.eflags &= ~(X86_EFLAGS_OF | X86_EFLAGS_SF | X86_EFLAGS_ZF |
>                             X86_EFLAGS_PF | X86_EFLAGS_CF);

And here.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel